Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search grounding #558

Merged
merged 17 commits into from
Sep 24, 2024
Merged

Search grounding #558

merged 17 commits into from
Sep 24, 2024

Conversation

shilpakancharla
Copy link
Collaborator

Updated test cases and content_types.py to include GoogleSearchRetrieval as a Tool.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Sep 16, 2024
MarkDaoust
MarkDaoust requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from pair programming session.

google/generativeai/types/content_types.py Outdated Show resolved Hide resolved
google/generativeai/types/content_types.py Show resolved Hide resolved
google/generativeai/types/content_types.py Show resolved Hide resolved
google/generativeai/types/content_types.py
@@ -656,6 +677,7 @@ class Tool:
def __init__(
self,
function_declarations: Iterable[FunctionDeclarationType] | None = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check that only one of these is set?

google/generativeai/types/content_types.py Show resolved Hide resolved
google/generativeai/types/content_types.py Show resolved Hide resolved
tests/test_content.py Outdated Show resolved Hide resolved
tests/test_content.py Outdated Show resolved Hide resolved
tests/test_content.py Outdated Show resolved Hide resolved
tests/test_content.py Outdated Show resolved Hide resolved
shilpakancharla and others added 2 commits September 19, 2024 16:48
@shilpakancharla
Update test cases and _make_search_grounding
c5cebf2
@MarkDaoust
fix tests
e60841e 
Change-Id: Ib9e19d78861da180f713e09ec93d366d5d7b5762
shilpakancharla and others added 4 commits September 19, 2024 17:08
@shilpakancharla
Remove print statement
2f67470
@MarkDaoust
Fix tuned model tests
d15431b 
Change-Id: I5ace9222954be7d903ebbdabab9efc663fa79174
@MarkDaoust
Fix tests
eff6ea5 
Change-Id: Ifa610965c5d6c38123080a7e16416ac325418285
@MarkDaoust
format
4e76777 
Change-Id: Iab48a9400d53f3cbdc5ca49c73df4f6a186a867b
@MarkDaoust MarkDaoust marked this pull request as draft September 23, 2024 18:17
@MarkDaoust MarkDaoust marked this pull request as ready for review September 24, 2024 16:05
MarkDaoust
MarkDaoust previously approved these changes Sep 24, 2024
View reviewed changes
@MarkDaoust
fix typing
3f348fa 
Change-Id: If892b20ca29d1afb82c48ae1a49bef58e0421bab
@MarkDaoust
Format
a26120b 
Change-Id: I51a51150879adb3d4b6b00323e0d8eaf4c0b2515
@MarkDaoust MarkDaoust merged commit d5103eb into google-gemini:main Sep 24, 2024
9 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDaoust MarkDaoust MarkDaoust approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilpakancharla @MarkDaoust